-
-
Notifications
You must be signed in to change notification settings - Fork 143
fix(auth): support running migrations for the first time during auth installation #1823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(auth): support running migrations for the first time during auth installation #1823
Conversation
|
Hey, thanks! I don't think hardcoding the migration here is the right approach. I'd probably look into fixing the migration command inside the auth installer instead. |
yup, I agree, will be done 👍🏻 |
@innocenzi Hey, maybe a combination of checking in the manager and taking action in the installer, keeping the manager as our source of truth for whether the migrations table exists |
|
@brendt @innocenzi what do you guys think about this one ? |
|
Makes me wonder: why don't we just run |
just updated it, maybe something like this ? |
|
No I don't think this is the right approach because migrate:up will run all migrations, and you shouldn't have to manually run another after that. I'll take a look at this myself |
fixes #1684